From 62a5793e7104b1806a7b7ebe270632af1a4cd9c0 Mon Sep 17 00:00:00 2001
From: ShittyKopper <shittykopper@w.on-t.work>
Date: Mon, 27 Nov 2023 23:55:43 +0300
Subject: [PATCH] fix: don't show filename as alt text
---
packages/frontend/src/components/MkMediaBanner.vue | 2 +-
packages/frontend/src/components/MkMediaImage.vue | 8 ++++----
packages/frontend/src/components/MkMediaList.vue | 4 ++--
packages/frontend/src/components/MkMediaVideo.vue | 2 +-
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/packages/frontend/src/components/MkMediaBanner.vue b/packages/frontend/src/components/MkMediaBanner.vue
index 4594c8a1db..7b0387cefe 100644
--- a/packages/frontend/src/components/MkMediaBanner.vue
+++ b/packages/frontend/src/components/MkMediaBanner.vue
@@ -14,7 +14,7 @@ SPDX-License-Identifier: AGPL-3.0-only
<audio
ref="audioEl"
:src="media.url"
- :title="media.name"
+ :title="media.comment ?? undefined"
controls
preload="metadata"
/>
diff --git a/packages/frontend/src/components/MkMediaImage.vue b/packages/frontend/src/components/MkMediaImage.vue
index 0040f00dc2..ef57cea32a 100644
--- a/packages/frontend/src/components/MkMediaImage.vue
+++ b/packages/frontend/src/components/MkMediaImage.vue
@@ -8,10 +8,10 @@ SPDX-License-Identifier: AGPL-3.0-only
<component
:is="disableImageLink ? 'div' : 'a'"
v-bind="disableImageLink ? {
- title: image.name,
+ title: image.comment,
class: $style.imageContainer,
} : {
- title: image.name,
+ title: image.comment,
class: $style.imageContainer,
href: image.url,
style: 'cursor: zoom-in;'
@@ -22,8 +22,8 @@ SPDX-License-Identifier: AGPL-3.0-only
:src="(defaultStore.state.dataSaver.media && hide) ? null : url"
:forceBlurhash="hide"
:cover="hide || cover"
- :alt="image.comment || image.name"
- :title="image.comment || image.name"
+ :alt="image.comment"
+ :title="image.comment"
:width="image.properties.width"
:height="image.properties.height"
:style="hide ? 'filter: brightness(0.7);' : null"
diff --git a/packages/frontend/src/components/MkMediaList.vue b/packages/frontend/src/components/MkMediaList.vue
index 46e32ef2d8..ff227b0ef9 100644
--- a/packages/frontend/src/components/MkMediaList.vue
+++ b/packages/frontend/src/components/MkMediaList.vue
@@ -156,8 +156,8 @@ onMounted(() => {
[itemData.w, itemData.h] = [itemData.h, itemData.w];
}
itemData.msrc = file.thumbnailUrl;
- itemData.alt = file.comment ?? file.name;
- itemData.comment = file.comment ?? file.name;
+ itemData.alt = file.comment ?? undefined;
+ itemData.comment = file.comment;
itemData.thumbCropped = true;
});
diff --git a/packages/frontend/src/components/MkMediaVideo.vue b/packages/frontend/src/components/MkMediaVideo.vue
index 4f8560f0f1..a1950b110a 100644
--- a/packages/frontend/src/components/MkMediaVideo.vue
+++ b/packages/frontend/src/components/MkMediaVideo.vue
@@ -17,7 +17,7 @@ SPDX-License-Identifier: AGPL-3.0-only
ref="videoEl"
:class="$style.video"
:poster="video.thumbnailUrl"
- :title="video.comment"
+ :title="video.comment ?? undefined"
:alt="video.comment"
preload="none"
controls
--
GitLab