From bf71b311239478f779f42c63e30b2e694f6c25db Mon Sep 17 00:00:00 2001 From: syuilo <syuilotan@yahoo.co.jp> Date: Wed, 17 Apr 2019 16:59:39 +0900 Subject: [PATCH] Update CONTRIBUTING.md --- CONTRIBUTING.md | 36 +++++++++++++++++++++++++++++++++--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6825225e0e..edc6244d39 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -46,10 +46,40 @@ Convert ãª(na) to ã«ã‚ƒ(nya) Revert Nyaize ## Code style -### Use semicolon -To avoid ASI Hazard +### セミコãƒãƒ³ã‚’çœç•¥ã—ãªã„ +ASI Hazardã‚’é¿ã‘ã‚‹ãŸã‚ã§ã‚‚ã‚ã‚‹ + +### ä¸æ‹¬å¼§ã‚’çœç•¥ã—ãªã„ +Bad: +``` ts +if (foo) + bar; +else + baz; +``` + +Good: +``` ts +if (foo) { + bar; +} else { + baz; +} +``` + +ãŸã ã—**`if`ãŒä¸€è¡Œ**ã®æ™‚ã ã‘ã¯çœç•¥ã—ã¦ã‚‚良ㄠ+Good: +``` ts +if (foo) bar; +``` + +### `export default`を使ã‚ãªã„ +インテリセンスã¨ç›¸æ€§ãŒæ‚ªã‹ã£ãŸã‚Šã™ã‚‹ãŸã‚ + +å‚考: +* https://gfx.hatenablog.com/entry/2017/11/24/135343 +* https://basarat.gitbooks.io/typescript/docs/tips/defaultIsBad.html -### Don't use `export default` Bad: ``` ts export default function(foo: string): string { -- GitLab