Range requests from proxy do not seem to set the correct status code
What happened? (Please give us a brief description of what happened.)
When returning a range request from the proxy handler, Sharkey does not set the correct status (206 Partial Content) to indicate it. The file serving code just above does do it.
Came across this while investigating https://discord.com/channels/1126590789322035230/1227062070164586506 (video scrubbing issues on Chrome), not exactly sure if it's the reason why that's broken but it's a likely candidate.
I'm unsure about the exact setup the person on the thread runs so I'll not fill in those fields.
What did you expect to happen? (Please give us a brief description of what you expected to happen.)
The correct status code to be sent.
Version (What version of Sharkey is your instance running? You can find this by clicking your instance's logo at the top left and then clicking instance information.)
Instance (What instance of Sharkey are you using?)
oshi.social
What type of issue is this? (If this happens on your device and has to do with the user interface, it's client-side. If this happens on either with the API or the backend, or you got a server-side error in the client, it's server-side.)
server-side
What browser are you using? (Client-side issues only)
What operating system are you using? (Client-side issues only)
How do you deploy Sharkey on your server? (Server-side issues only)
What operating system are you using? (Server-side issues only)
Relevant log output (Please copy and paste any relevant log output. You can find your log by inspecting the page, and going to the "console" tab. This will be automatically formatted into code, so no need for backticks.)
Contribution Guidelines By submitting this issue, you agree to follow our Contribution Guidelines
- I agree to follow this project's Contribution Guidelines
- I have searched the issue tracker for similar issues, and this is not a duplicate.