fix scheduled replies becoming quote-boosts

What does this MR do?

Scheduling a reply will attach a random note as a quote. This MR stops that.

Thanks to @CenTdemeern1 for triggering this bug!

When the ScheduledNoteProcessor converts a scheduled reply into a real note, it calls findOneBy with an undefined note.renote, which probably caused a select without any where, so a random note gets attached as a quote.

The specific case that showed this bug "in the wild" was a bit more convoluted, see https://kitsunes.club/notes/a2h1y2rq9n, and compare with https://s.thenautilus.net/notes/a2h1y2rqx9

My instance errored out with:

WARN 1 [remote ap] Failed to resolve quote https://mastodon.social/users/DrALJONES/statuses/110586222749407429 for note https://kitsunes.club/notes/a2h1y2rq9n: StatusError: 404 Not Found

What happened?

• Charlotte scheduled a reply
• a random note was attached as a quote
• that note has been deleted on the original instance but not on kitsuclub's database
• the rest of fedi didn't notice the quote

The discrepancy in the two copies of the note (on kitsuclub and everywhere else) is not directly related to this bug, and is not even technically much of a bug…

Contribution Guidelines

By submitting this merge request, you agree to follow our Contribution Guidelines

• I agree to follow this project's Contribution Guidelines
• I have made sure to test this merge request