Skip to content

Fix note visibility in streaming API

What does this MR do?

Fixes three bugs in the streaming API that cause incorrect note and reaction visibility in various cases:

  1. Boosts of a reply to a blocked, blocking, or muted user may appear in timelines. Fixed by recursively calling isNoteMutedOrBlocked for pure renote targets.
  2. Reactions may be attributed to the wrong users in Channel, Hashtag, Role, and List timelines. Fixed by applying @piuvas's previous fix to these additional streaming channels.
  3. Boosts, quotes, and replies to a note from a blocked or muted user may appear in timelines. Fixed by calling NoteEntityService.hideNote from the channel implementations, to account for the fact that input PackedNote objects are created with skipHide flag set.

Contribution Guidelines

By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this merge request
Edited by Hazelnoot

Merge request reports

Loading