test(backend): kill many `any` in backend test (partial) (#14054)
* kill any on utils:api * kill any on timeline test * use optional chain to kill TS2532 on timeline test 変更前: 該当ノートが見つからなければundefinedに対するプロパティアクセスとしてテストがクラッシュ 変更後: 該当ノートが見つからなければoptional chainがundefinedとして評価されるが、strictEqualの右辺がnon-nullableなためアサーションに失敗しテストがクラッシュ * kill `as any` for ApMfmService * kill argument any for api-visibility * kill argument any across a few tests * do not return value that has yielded from `await`-ing `Promise<void>` * force cast * runtime non-null assertion to coerce * rewrite `assert.notEqual(expr, null)` to `assert.ok(expr)` こうすることでassertion type扱いになり、non-nullableになる * change return type of `failedApiCall` to `void` 戻り値がどこにも使われていない * split bindings for exports.ts 型が合わなくて文句を言ってくるので適切に分割 * runtime non-null assertion * runtime non-null assertion * 何故かうまく行かないので、とりあえずXORしてみる * Revert "何故かうまく行かないので、とりあえずXORしてみる" This reverts commit 48cf32c930924840d0892af92d71b9437acb5844. * castAsErrorで安全ではないキャストを隠蔽 * 型アサーションの追加 * 型アサーションの追加 * 型アサーションの追加 * voidで値を返さない * castAsError * assert.ok => kill nullability * もはや明示的な型の指定は必要ない * castAsError * castAsError * 型アサーションの追加 * nullableを一旦抑止 * 変数を分離して型エラーを排除 * 不要なプロパティを削除する処理を隠蔽してanyを排除 * Repository type * simple type * assert.ok => kill nullability * revert `as any` drop reverts fe95c05b3f53266108128680d9358a3796844232 partialy * test: fix invalid assertion partially revert b99b7b5392d9d20c81dfee1346ba8b33ff9e1fbb * test: 52d8a54f により型が合うようになった部分の`as any`を除去 * format * test: apply https://github.com/misskey-dev/misskey/pull/14054#discussion_r1672369526 (part 1) * test: use non-null assertion to suppress too many error * Update packages/backend/test/utils.ts Co-authored-by: anatawa12 <anatawa12@icloud.com> --------- Co-authored-by: anatawa12 <anatawa12@icloud.com>
Showing
- packages/backend/src/core/activitypub/ApMfmService.ts 1 addition, 1 deletionpackages/backend/src/core/activitypub/ApMfmService.ts
- packages/backend/test/e2e/2fa.ts 16 additions, 14 deletionspackages/backend/test/e2e/2fa.ts
- packages/backend/test/e2e/api-visibility.ts 8 additions, 8 deletionspackages/backend/test/e2e/api-visibility.ts
- packages/backend/test/e2e/block.ts 7 additions, 5 deletionspackages/backend/test/e2e/block.ts
- packages/backend/test/e2e/clips.ts 6 additions, 6 deletionspackages/backend/test/e2e/clips.ts
- packages/backend/test/e2e/endpoints.ts 9 additions, 8 deletionspackages/backend/test/e2e/endpoints.ts
- packages/backend/test/e2e/exports.ts 38 additions, 32 deletionspackages/backend/test/e2e/exports.ts
- packages/backend/test/e2e/move.ts 40 additions, 28 deletionspackages/backend/test/e2e/move.ts
- packages/backend/test/e2e/mute.ts 36 additions, 36 deletionspackages/backend/test/e2e/mute.ts
- packages/backend/test/e2e/note.ts 46 additions, 29 deletionspackages/backend/test/e2e/note.ts
- packages/backend/test/e2e/renote-mute.ts 8 additions, 8 deletionspackages/backend/test/e2e/renote-mute.ts
- packages/backend/test/e2e/thread-mute.ts 5 additions, 5 deletionspackages/backend/test/e2e/thread-mute.ts
- packages/backend/test/e2e/timelines.ts 133 additions, 133 deletionspackages/backend/test/e2e/timelines.ts
- packages/backend/test/unit/ApMfmService.ts 4 additions, 4 deletionspackages/backend/test/unit/ApMfmService.ts
- packages/backend/test/unit/FileInfoService.ts 25 additions, 76 deletionspackages/backend/test/unit/FileInfoService.ts
- packages/backend/test/utils.ts 21 additions, 11 deletionspackages/backend/test/utils.ts
Loading
Please register or sign in to comment