Skip to content
Snippets Groups Projects
Commit 90e9480b authored by dakkar's avatar dakkar
Browse files

fix `offestMode` in `MkPagination` - fixes #622

3f73251d reworked the way `offsetMode`
is handled, to allow reactive `ComputedRef<boolean>` in addition to a
simple `boolean`, so that custom emoji search could easily switch
between the faster `sinceId`/`untilId` pagination and the slower
`offset` as needed.

Or it would have, if I had written the correct expression! I wrote
`props.offsetMode` instead of `props.pagination.offsetMode`, so it was
always `false`

I have *no idea* how I didn't notice, I swear I tested it ☹️

Anyway, factoring out the nested ternaries makes the whole thing
clearer and less prone to mistakes. And I have tested it, this time.
parent 994b6ef7
No related branches found
No related tags found
Loading
Pipeline #1009 failed with stage
in 10 minutes and 16 seconds
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment