processing follow activity fails if user has an alias (alsoKnownAs) from a (currently) offline instance
Created by: ShittyKopper
💡 Summary
UpdateValuesMissingError: Cannot perform update query because update values are not defined. Call "qb.set(...)" method to specify updated values.
at UpdateQueryBuilder.createUpdateExpression (/sharkey/node_modules/.pnpm/typeorm@0.3.17_ioredis@5.3.2_pg@8.11.3/node_modules/typeorm/query-builder/UpdateQueryBuilder.js:430:19)
at UpdateQueryBuilder.getQuery (/sharkey/node_modules/.pnpm/typeorm@0.3.17_ioredis@5.3.2_pg@8.11.3/node_modules/typeorm/query-builder/UpdateQueryBuilder.js:34:21)
at UpdateQueryBuilder.getQueryAndParameters (/sharkey/node_modules/.pnpm/typeorm@0.3.17_ioredis@5.3.2_pg@8.11.3/node_modules/typeorm/query-builder/QueryBuilder.js:274:28)
at UpdateQueryBuilder.execute (/sharkey/node_modules/.pnpm/typeorm@0.3.17_ioredis@5.3.2_pg@8.11.3/node_modules/typeorm/query-builder/UpdateQueryBuilder.js:81:50)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async ApPersonService.updatePerson (file:///sharkey/packages/backend/built/core/activitypub/models/ApPersonService.js:450:9)
at async AccountMoveService.validateAlsoKnownAs (file:///sharkey/packages/backend/built/core/AccountMoveService.js:338:17)
at async UserFollowingService.follow (file:///sharkey/packages/backend/built/core/UserFollowingService.js:152:32)
at async ApInboxService.follow (file:///sharkey/packages/backend/built/core/activitypub/ApInboxService.js:175:9)
at async ApInboxService.performOneActivity (file:///sharkey/packages/backend/built/core/activitypub/ApInboxService.js:139:13)
at async ApInboxService.performActivity (file:///sharkey/packages/backend/built/core/activitypub/ApInboxService.js:119:13)
at async InboxProcessorService.process (file:///sharkey/packages/backend/built/queue/processors/InboxProcessorService.js:175:9)
at async Worker.processJob (/sharkey/node_modules/.pnpm/bullmq@4.15.4/node_modules/bullmq/dist/cjs/classes/worker.js:385:28)
at async Worker.retryIfFailed (/sharkey/node_modules/.pnpm/bullmq@4.15.4/node_modules/bullmq/dist/cjs/classes/worker.js:572:24)🥰 Expected Behavior
the follow activity should go through
🤬 Actual Behavior
the job gets delayed, presumably until the other instance is back online (which, in some cases, may never happen)
📝 Steps to Reproduce
get followed by an actor with an alsoKnownAs pointing to a dead instance
💻 Frontend Environment
* Model and OS of the device(s):
* Browser:
* Server URL:
* Misskey:
🛰 Backend Environment (for server admin)
* Installation Method or Hosting Service: docker
* Misskey: 2023.12.0.beta2.kopper3
* Node: whatever one's on the docker image idk
* PostgreSQL: psql (PostgreSQL) 16.1 (Debian 16.1-1.pgdg120+1)
* Redis: redis-cli 7.2.3
* OS and Architecture: debian 12 arm64