bug: Not every account is "visible" from "add to list" dialog

Created by: grischa

💡 Summary

I try to add some accounts to a list. I follow none of them. Most of them can be added to my list, but two don't

🥰 Expected Behavior

I shoud be able to add any (at least public) account to my list.

🤬 Actual Behavior

Some of them don't get visible in that dialogue although the user search is finding them.

📝 Steps to Reproduce

Goto lists, add a new one or edit an existing Add user to list Dialog "Choose user" Enter "orkenspaltertv" into the first input, enter "rollenspiel.social" into the second => no account is listed. Enter "Nexus_Berlin" into the first input => no account is listed.

But when I search @orkenspaltertv@rollenspiel.social or @Nexus_Berlin@rollenspiel.social they are found in user search. This happens on shonk and dev. I can't see something special with these two accounts. And another account from the same (Mastodon) instance shows up w/o any problem.

💻 Frontend Environment

* Model and OS of the device(s): Ubuntu Laptop
* Browser: Firefox latest
* Server URL: shonk and def
* Misskey: Well.. ^^

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service:
* Misskey:
* Node:
* PostgreSQL:
* Redis:
* OS and Architecture:

Do you want to address this bug yourself?

• Yes, I will patch the bug myself and send a pull request

I feel like this fundamentally lies in how the endpoint it uses works after some experimenting it turns out to mainly only shows users if you follow them essentially it would prob require a complete makeover so it would show all users

the component used is MkUserSelectDialog (which I think is the one used every time we need to select a user). It calls users/search-by-username-and-host, which delegates to UserSearchService.search

that search returns first users you follow who have been active in the last month, then other users you follow, then users you don't follow who have been active in the last month, then all other users. These queries are filtered by username & host prefixes as you type them in the dialog. The function will never return more than 10 users (the default limit).

As most of that code is new since 2024.7, I'm going to consider this bug fixed.

closed

changed the description