the welcome page may featured cw-ed notes and show them in full
What happened?
The welcome page (front page for non-logged-in users) shows a scrolling list of "featured" notes on the right hand side.
These notes are shown by a simplified rendering component https://activitypub.software/TransFem-org/Sharkey/-/blob/develop/packages/frontend/src/pages/welcome.timeline.vue that does not honour CW (at least the MkMediaList
honours the "sensitive" flag on attachments…)
(reported by @Amelia)
What did you expect to happen?
Either CW-ed notes are never shown, or are shown collapsed.
Version
2024.3
Notes
Probably correct ways to address this:
- filter out CW-ed notes in the rendering component
- display them collapsed (but I'm pretty sure we can't re-use
MkCwButton
)
Probably wrong ways:
- filter out CW-ed notes in the backend (the same api endpoint is used in other places)
- avoid ever featuring CW-ed notes (calls to
featuredService.updateGlobalNotesRanking
)
Contribution Guidelines By submitting this issue, you agree to follow our Contribution Guidelines
- I agree to follow this project's Contribution Guidelines
- I have searched the issue tracker for similar issues, and this is not a duplicate.