`api/endpoints` is outdated

What happened?

Sharkey has endpoint notes/edit but the response of endpoints does not contain it.

https://activitypub.software/TransFem-org/Sharkey/-/blob/05a568e5aa82a7aaf47648871c3d45e70fcdddf4/packages/backend/src/server/api/endpoints.ts#L663-664

I am a developer of a Misskey client app. For my app, I want to show "Edit note" button only if the server supports note editing feature, since plain Misskey does not support it. To detect if users can edit notes, the app uses endpoints response and check if it contains notes/edit. This approach worked well for other forks like Firefish and Iceshrimp, but not for Sharkey.

I am not sure if there are other missing endpoints.

What did you expect to happen?

Return all endpoints.

Version

2024.5.0

What type of issue is this?

server-side

Contribution Guidelines By submitting this issue, you agree to follow our Contribution Guidelines

• I agree to follow this project's Contribution Guidelines
• I have searched the issue tracker for similar issues, and this is not a duplicate.

It is listed in the endpoints at this line https://activitypub.software/TransFem-org/Sharkey/-/blob/05a568e5aa82a7aaf47648871c3d45e70fcdddf4/packages/backend/src/server/api/endpoints.ts#L690 as well as the notes/versions endpoints for note history right after

more precisely: that list is used to automatically generate the response at https://activitypub.software/TransFem-org/Sharkey/-/blob/05a568e5aa82a7aaf47648871c3d45e70fcdddf4/packages/backend/src/server/api/endpoints/endpoints.ts#L42 so that response should always contain all supported endpoints.

I've checked on a couple of instances and notes/edit is definitely listed. @poppingmoon Can you give us an example of Sharkey instance that does not list it?

(thank you for reporting a possible problem!)

Sorry, I think I misunderstood. I have tested with a local instance and it contained notes/edit in response as you mentioned.

Thank you both for your quick response.

closed