Quotes with a CW and blank content are treated as plain boosts in 2024.9

What happened? On the staging Sharkey instance, I've noticed that quotes that include a CW and no content are treated as normal boosts.

What did you expect to happen? Given that I haven't explicitly patched in that behavior on eepy.moe, I'm going to assume this is a regression, and that the intended behavior has changed due to the merge from upstream.

Version staging.joinsharkey.org: 2024.9.1-rc, eepy.moe: 2024.8.2.1-eepy

Instance staging.joinsharkey.org, eepy.moe

What type of issue is this? Client side? Not sure...

What browser are you using? Firefox

What operating system are you using? Linux

How do you deploy Sharkey on your server? staging.joinsharkey.org: Docker-compose for Postgres & Redis, Sharkey runs on the host. eepy.moe: Fully docker-compose based setup.

What operating system are you using? Linux in both cases.

Contribution Guidelines By submitting this issue, you agree to follow our Contribution Guidelines

• I agree to follow this project's Contribution Guidelines
• I have searched the issue tracker for similar issues, and this is not a duplicate.

added bug label

marked this issue as related to #481 (closed)

can't replicate: https://staging.joinsharkey.org/notes/9z8pd758gilp0053

the note I saw it happen with was: https://staging.joinsharkey.org/notes/9z8oawfj4mlj0024 / https://eepy.moe/notes/9z8oawfjgrkd05tl

ooh, might it be… NoteCreateService has two different implementations of isQuote and isRenote, is it possible that they confuse each other? (one pair are methods, one pair are imported)

can you describe exactly what you did to create the "wrong" notes? What I did:

• take a random note on the staging instance
• press the quote button on that note
• press the "eye" icon on they compose dialog
• wrote «CW!» in the comment/cw field
• post

and it produced a quote.

• I took a note from a 3rd party instance (snug.moe)
• Pressed the quote button on that note on eepy.moe
• Pressed the "eye" icon in the compose dialog
• Wrote a CW in the field
• Posted
• And it produced a quote on eepy.moe, but NOT staging.joinsharkey.org

Could you try making the same quote from staging.joinsharkey.org? There could be a difference between local and remote note creation.

well, I killed staging.joinsharkey.org (by accident) a few hours after making this issue, so...

I did the exact same steps on staging, and it worked fine, see my previous comment.

I have also done the same steps on two local test instances, once quoting a local note, once quoting a remote note, and everything still worked fine. Both instances can see the quote correctly.

Just tried it as well with the same steps on local dev and it also worked fine.

can we close this?