Fedilab requesting guidance on how to implement notifications through Mastodon API recreation

Hi,

Over in this ticket on FediLab we're trying to figure out how to parse notifications from the Mastodon API implementation. At the moment, we're a touch confused because it looks like notifications ought to be being translated in a specific way, and they aren't. It seems like reactions are supposed to be transformed into favourite types, but are not, leading to them being displayed as an empty section in the FediLab notifications panel

added question label

Our Mastodon API implementation is rather broken in many ways, unfortunately. I can take a look but without knowing how notifications are meant to work there isn't really much I can do.

At the moment, it looks like the line that translates reactions might not be working correctly

if (notif.type !== 'follow' && notif.type !== 'follow_request' && notif.type === 'reaction') notif.type = 'favourite';

I'm fairly sure this should mean that Fedilab receives a like (albeit with extra info), but I'm told that it is not

So I figured out what is going on, Megalodon converts misskey reaction to emoji_reaction (for mastodon forks with emoji support) but since the converter in the api checks for the type reaction before turning it into favourite it obviously ends up not working since by the time the sharkey backend pulls the notification in from megalodon client it is called emoji_reaction

Megalodon part:

https://activitypub.software/TransFem-org/Sharkey/-/blob/develop/packages/megalodon/src/misskey/api_client.ts?ref_type=heads#L434

https://activitypub.software/TransFem-org/Sharkey/-/blob/develop/packages/megalodon/src/misskey/api_client.ts?ref_type=heads#L446

https://activitypub.software/TransFem-org/Sharkey/-/blob/develop/packages/megalodon/src/misskey.ts?ref_type=heads#L2053

https://activitypub.software/TransFem-org/Sharkey/-/blob/develop/packages/megalodon/src/notification.ts?ref_type=heads#L8

Backend part:

https://activitypub.software/TransFem-org/Sharkey/-/blob/develop/packages/backend/src/server/api/mastodon/endpoints/notifications.ts?ref_type=heads#L30-L31

So the fix would be to either change the check in the backend to emoji_reaction but this would essentially break apps which support emoji reactions

could we modify the converter to recognize emoji_reaction as an alias of reaction?

I guess that could be an option. I wish there would still be a simple way to test mastodon api changes

Would a reasonable alternative be for apps to look for an emoji_reaction type, since some Mastodon instances support this anyways? I mean, if we're restricting this to just FediLab, that seems like the easiest solution here