align Sk & Mk variants of components
Created by: dakkar
What
minimising the differences between the Mk*
components and our Sk*
components
Why
to make it easier to import future changes from upstream and make sure we're not missing fixes
Additional info (optional)
- the whitespace changes are in our real-time update callbacks, my editor indented them inconsistently the first time
- upstream added some type annotiations, so I copied them in our variants
-
SkNoteDetailed
was missing a reaction sound - I think
MkNote
should callnotes/like
the same way asSkNote
does, instead ofnotes/reactions/create
(there's a call to that endpoint in both components, a few lines below)
Checklist
-
Read the contribution guide -
Test working in a local environment -
(If needed) Add story of storybook -
(If needed) Update CHANGELOG.md -
(If possible) Add tests