Skip to content
Snippets Groups Projects

some fixes to NoteEdit and muting

Merged Ghost User requested to merge gh-b77c0252/376/unknown/maybe-mute-on-edit into develop

Created by: dakkar

What

There have been a bunch of changes to NoteCreateService since the creation of NoteEditService, that had not been applied to the latter. This PR does that. It also adds the recent muting improvements, because if a muted note gets edited, we still don't want to be notified about it. Finally, I think the current logic around muted threads and muted users is wrong: we want to notify when neither the thread nor the user are muted; otherwise, for example, notes in a muted thread from a non-muted user would get notified.

I've not actually tested this, but at least it builds.

Why

NoteEdit should stay as close as possible to NoteCreate

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests
Edited by dakkar

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading