allow disabling achievement notifications #319
What does this PR do?
Users can now disable the notifications for earning achievements.
This is currently the only configurable notification type that can only be set to "all" or "none", all the others allow filtering by sender user, so I had to tweak the drop-down
This opens the way to also easily make note
, roleAssigned
and
followRequestAccepted
configurable.
Tested using the API console and sending requests to
i/claim-achievement
. When the setting was "all", the achievement was
notified and it appeared in /my/achievements
; when the setting was
"none", the achievement only appeared in /my/achievements
but no
notification was generated.
Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines
-
I agree to follow this project's Contribution Guidelines -
I have made sure to test this pull request
Merge request reports
Activity
added enhancement label
- Resolved by dakkar
Pretty sure
roleAssigned
also has no sender since it happens when you well obviously get a role assigned to you which can be done conditionally or manually but I never got one of those types of notifications so can't tell much
mentioned in commit 0f1fc416