handle non-ASCII emoji names
All threads resolved!
All threads resolved!
What does this PR do?
Together with sfm-js!2 (merged), this should provide complete support for non-ASCII names of custom emoji.
In addition to always using the more inclusive regexp for validating emoji names, we also need to normalize emoji names, aliases, categories.
The latter point is necessary to allow matching, for example, ä
against a
+combining diaeresis.
Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines
-
I agree to follow this project's Contribution Guidelines -
I have made sure to test this pull request
Merge request reports
Activity
Filter activity
assigned to @dakkar
- Resolved by dakkar
added 1 commit
- b6f41a28 - pull in sfm-js that supports non-ascii in emoji names
- Resolved by dakkar
added 1 commit
- 0f3764ff - teach ReactionService about non-ASCII emoji names
- Resolved by dakkar
There's a lot of duplicate normalization calls. Is there any way to merge them into a common routine?
mentioned in commit d0a2708f
added federation label
Please register or sign in to reply