Fixed sharkey randomly clearing notifications

What does this PR do? (Please give us a brief description of what this PR does.) The PR makes it so notifications don't randomly get marked as read and are only marked as read when the mark all as read button is pressed. More info in the issue here Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

• I agree to follow this project's Contribution Guidelines
• I have made sure to test this pull request

packages/frontend/src/components/MkNotifications.vue

@@ -29,6 +29,7 @@ SPDX-License-Identifier: AGPL-3.0-only
 
 <script lang="ts" setup>
 import { onUnmounted, onDeactivated, onMounted, computed, shallowRef, onActivated } from 'vue';
+import * as Misskey from 'misskey-js';
 import MkPagination from '@/components/MkPagination.vue';
 import XNotification from '@/components/MkNotification.vue';
 import MkDateSeparatedList from '@/components/MkDateSeparatedList.vue';
@@ -40,7 +41,6 @@ import { notificationTypes } from '@/const.js';
 import { infoImageUrl } from '@/instance.js';
 import { defaultStore } from '@/store.js';
 import MkPullToRefresh from '@/components/MkPullToRefresh.vue';
-import * as Misskey from 'misskey-js';
 
 const props = defineProps<{
 	excludeTypes?: typeof notificationTypes[number][];
@@ -52,12 +52,14 @@ const pagination = computed(() => defaultStore.reactiveState.useGroupedNotificat
 	endpoint: 'i/notifications-grouped' as const,
 	limit: 20,
 	params: computed(() => ({
+		markAsRead: false,
 		excludeTypes: props.excludeTypes ?? undefined,
 	})),
 } : {
 	endpoint: 'i/notifications' as const,
 	limit: 20,
 	params: computed(() => ({
+		markAsRead: false,
 		excludeTypes: props.excludeTypes ?? undefined,
 	})),
 });

[dakkar]

could you put this back here? unless there's a very good reason, we'd like to stay as close as upstream as possible!

[Leah]

Hmm it seems it autoformats back up there on save. It would seem this is due to the project config?

[Leah]

Other than that is this PR fine then?

[dakkar]

have you checked that the behaviours I pointed out in my other comments don't make the clearing even more random?

[Leah]

From my tests it seems less random. Are there any specific tests I should try? Its a bit hard to test on a local instance where I don't get a lot of notifications so I'm sending a lot of test notifications. But also telling it to not clear in this case would only make it clear less not more randomly