Skip to content
Snippets Groups Projects

fix custom emoji pagination when searching - fixes #490

Merged dakkar requested to merge feature/490-fix-emoji-pagination into develop

What does this PR do?

Paginate in offset mode when querying custom emoji.

Since the backend sorts emojis by name length when a query is present, the normal pagination with sinceId / untilId does not work reliably.

offsetMode is better in this case, although it will produce non-stable results if custom emojis that match the query are added or removed while we paginate. I believe this is an acceptable trade-off.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading