fix custom emoji pagination when searching - fixes #490
What does this PR do?
Paginate in offset mode when querying custom emoji.
Since the backend sorts emojis by name length when a query is present, the normal pagination with sinceId
/ untilId
does not work reliably.
offsetMode
is better in this case, although it will produce non-stable results if custom emojis that match the query are added or removed while we paginate. I believe this is an acceptable trade-off.
Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines
-
I agree to follow this project's Contribution Guidelines -
I have made sure to test this pull request
Merge request reports
Activity
Filter activity
requested review from @fEmber, @esm, @Leah, @supakaity, and @luna
added 94 commits
-
2bb313e1...f1d96b8a - 91 commits from branch
develop
- 3f73251d - allow computed `offsetMode` in `MkPagination` - #490 (closed)
- 9d911963 - allow `offset` in `admin/emoji/list` - #490 (closed)
- a676b0ee - paginate in offset mode when querying emoji - fixes #490 (closed)
Toggle commit list-
2bb313e1...f1d96b8a - 91 commits from branch
mentioned in commit 88694876
Please register or sign in to reply