What does this PR do?
With these changes, we actually edit notes in more cases.
Before this, changing visibility did not have any effect (if we don't want to allow editing visibility, we need to disable the drop-down in the editing window in the frontend!)
Also, changing attachments did not have any effect, either. Adding a check that oldnote.fileIds
is different from data.files.map(file => file.id)
would not be enough, because editing the alt-text of an existing attachment would still not trigger the actual editing. Determining whether alt-text has been changed is a pain (e.g. if I edit the alt-text in the Drive, then edit the note that has that file attached, I would expect the note to be re-sent with the new alt-text). Therefore, we're publishing an edit event whenever a note has attachments, even if we can't see what changed.
Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines