select note component in <setup>
What does this PR do?
As an experiment, I tried to move the logic to select the correct note component (MkNote
/SkNote
) from the "template" to the "setup" section. It seems to work fine.
This makes our templates much more similar to upstream's, making merges simpler.
Changing note design is already marked as needing a reload, so having non-reactive code that selects the note component is not a problem.
Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines
-
I agree to follow this project's Contribution Guidelines -
I have made sure to test this pull request
Merge request reports
Activity
- Resolved by dakkar
This seems to be working fine in my case but do note that there are also two pages and one component where it still goes off the old code in this MR those being
components/MkNotifications.vue
pages/favorites.vue
pages/user/home.vue
added 473 commits
-
49d03e01...717696c4 - 472 commits from branch
develop
- 513a8e5d - select note component in <setup>
-
49d03e01...717696c4 - 472 commits from branch
mentioned in commit 518de221