Skip to content
Snippets Groups Projects

select note component in <setup>

Merged dakkar requested to merge feature/select-note-style-in-setup into develop

What does this PR do?

As an experiment, I tried to move the logic to select the correct note component (MkNote/SkNote) from the "template" to the "setup" section. It seems to work fine.

This makes our templates much more similar to upstream's, making merges simpler.

Changing note design is already marked as needing a reload, so having non-reactive code that selects the note component is not a problem.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading