Skip to content
Snippets Groups Projects

look inside `url` when checking activity origin - #512

Merged dakkar requested to merge feature/512-look-inside-urls into develop

What does this PR do?

The previous assertion that:

if it's a complicated thing and the activity.id doesn't match, I think we're fine rejecting the activity

was wrong: at least peertube sends activities that have url as an array of objects.

Notice that this does not, in fact, fix #512 (closed): the peertube activity does not contain its short URL (https://example.com/w/someid), so there's no way to confirm that it is the activity we requested.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading