Skip to content

avoid `await` at top-level in setup - fixes frontend tests

dakkar requested to merge feature/fix-frontend-tests into develop

What does this PR do?

Putting an await at the top level inside a Vue setup script marks the whole setup as async (correctly), which confuses the tests.

We don't really need to block setup until we've talked with listenbrainz: we can fire the request, and update listenbrainzdata once we have the response. Of course we also need to make listenbrainzdata a ref, otherwise the UI won't update.

Tested, it works.

After merging this and the future-2024-05-31 branch, we should be able to run tests in our CI pipeline!

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports