Skip to content
Snippets Groups Projects

avoid `await` at top-level in setup - fixes frontend tests

Merged dakkar requested to merge feature/fix-frontend-tests into develop
All threads resolved!

What does this PR do?

Putting an await at the top level inside a Vue setup script marks the whole setup as async (correctly), which confuses the tests.

We don't really need to block setup until we've talked with listenbrainz: we can fire the request, and update listenbrainzdata once we have the response. Of course we also need to make listenbrainzdata a ref, otherwise the UI won't update.

Tested, it works.

After merging this and the future-2024-05-31 branch, we should be able to run tests in our CI pipeline!

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Merge request pipeline #649 failed

Merge request pipeline failed for 28a5ab67

Approval is optional

Merged by avatar (Jan 1, 2025 5:14pm UTC)

Merge details

  • Changes merged into with 9520a14c.
  • Deleted the source branch.

Pipeline #658 failed

Pipeline failed for 9520a14c on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marie resolved all threads

    resolved all threads

  • Marie approved this merge request

    approved this merge request

  • dakkar mentioned in issue #543 (closed)

    mentioned in issue #543 (closed)

  • Ghost User approved this merge request

    approved this merge request

  • A deleted user merged

    merged

  • Ghost User mentioned in commit 9520a14c

    mentioned in commit 9520a14c

  • Please register or sign in to reply
    Loading