Skip to content
Snippets Groups Projects

better block display for `<bdi>` elements - fixes #550

Merged dakkar requested to merge feature/550-fix-bidi-block into develop

What does this PR do?

We use MfM in all sorts of places, and only some of them are actual blocks. We can now tell the Mfm component to make the top-level <bdi> a block when we need to (mostly note bodies, user descriptions, announcements) and leave it inline in all other places.

This should still rendener inline rtl content embedded in ltr text in a sensible way, while providing right-alignment for fully rtl blocks.

Examples:

image

centered text, quoted text (I don't know why that stays left-aligned, couldn't make it right-aligned), regular text; notice that the usernames in the reaction viewer popup are not broken

image

replies that start with mentions are correctly bidi, and I think correctly aligned

@dimkr can you re-check this? does it still look decent?

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading