Skip to content
Snippets Groups Projects

fix #520, render usernames containing custom emoji in welcome toast properly

Merged fix #520, render usernames containing custom emoji in welcome toast properly
All threads resolved!
Merged Tess K requested to merge tess/Sharkey:bugfix/520-welcome-message-custom-emoji into develop
All threads resolved!

What does this PR do? This PR fixes rendering of usernames containing custom emojis in the "Welcome Back, ${username}" toast message by wrapping the MkToast message in an Mfm tag. The plain argument for the m makes sure that for example "\n" won't get converted to a br element.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Before:

Welcome_back__Super_cool

After:

Welcome_back__Super_cool

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tess K added 2 commits

    added 2 commits

    • ce197bc2 - add ability to conditionally wrap toast message in Mfm tag
    • e7b87c02 - Pass renderMfm as true to wrap welcome back toast in Mfm

    Compare with previous version

  • dakkar resolved all threads

    resolved all threads

  • dakkar approved this merge request

    approved this merge request

  • Marie approved this merge request

    approved this merge request

  • merged

  • Marie mentioned in commit 8f3549b4

    mentioned in commit 8f3549b4

  • Please register or sign in to reply
    Loading