Skip to content
Snippets Groups Projects

feat: add an option to collapse replies

Merged sugar requested to merge (removed):collapse-replies into develop
All threads resolved!

What does this PR do? (Please give us a brief description of what this PR does.)

provides an option to collapse replies to make timeline more compact

collapsed replies look like this:

or with Misskey note layout:

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by sugar

      (this is related to #532 (closed))

      thank you for this!

      can you compare your implementation with kopper/Sharkey@f2f947fb ?

      From your screenshots, the collapsed note seems to hide a bit too much information, maybe we could show the full username? (the actual note "body", which is provided by getNoteSummary function, is probably good enough)

      minor: this is not about collapsing "replies", but collapsing the note being replied to (yes, appearNote.reply is a terrible name, should have probably been .inReplyTo, but it wasn't our choice…), so could you change the text and the identifiers?

      Edited by dakkar
  • sugar added 1 commit

    added 1 commit

    • c8081472 - replace reply with inReplyTo in in-reply-to collapse code

    Compare with previous version

  • dakkar
  • sugar added 2 commits

    added 2 commits

    • 9ce2c8c0 - include usernames in collapsed notes replied to
    • 460e7f05 - correct collapsed in reply to line alignment with small screen sizes

    Compare with previous version

  • sugar added 2 commits

    added 2 commits

    • c149734f - avoid renoteCollapsed dependency in inReplyToCollapsed
    • 30db323a - reduce margin-top for collapsed in replies to in small containers

    Compare with previous version

  • sugar added 1 commit

    added 1 commit

    • a061c6c2 - reduce margin-top for collapsed in replies to in small containers

    Compare with previous version

  • sugar added 1 commit

    added 1 commit

    • ed8b1b8f - keep renoteCollapsed as it was before adding reply collapse

    Compare with previous version

  • dakkar resolved all threads

    resolved all threads

  • dakkar approved this merge request

    approved this merge request

  • Marie approved this merge request

    approved this merge request

  • dakkar mentioned in commit a22450d4

    mentioned in commit a22450d4

  • merged

  • Please register or sign in to reply
    Loading