Skip to content
Snippets Groups Projects

preserve `ti-fw` classes for icons - fixes #580

Merged dakkar requested to merge feature/580-fix-ti-fw into develop

What does this PR do?

I thought that ti-fw was mostly useless, but it turns out that:

  • it affects the alignment of icons in many places
  • it's set separately in some places (e.g. packages/frontend/src/ui/_common_/navbar.ts has <i class="ti-fw" :class="[$style.itemIcon, navbarItemDef[item].icon]"></i>)

so we have to keep it around.

I've tested this the same way as +!559 (merged). It adds a bunch of ti-fw that are not in 2024.5 so we may still have some differences with respect to that release.

If things look worse with this change, we'll have to add ti-fw selectively, or remove it altogether.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading