Skip to content
Snippets Groups Projects

feat: implement `attachLdSignatureForRelays` to control signing of Relayed activities (#599)

All threads resolved!

What does this PR do? (Please give us a brief description of what this PR does.)

This PR implements #599 (closed) by adding a new setting attachLdSignatureForRelays. When enabled (default), Sharkey continues its existing behavior of attaching Linked-Data signatures to all relayed activities. When disabled, LD signatures are never generated. This improves privacy at the expense of increased inbound fetches and reduced relay effectiveness.

I have tested this on my own instance and seen no unexpected issues.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • dakkar
    • Resolved by dakkar

      Did you actually confirm that instances that receive Announces from relays of activities generated without ld signatures, fetch the activities from the source?

  • Hazelnoot added 1 commit

    added 1 commit

    Compare with previous version

  • dakkar resolved all threads

    resolved all threads

  • dakkar approved this merge request

    approved this merge request

  • Marie approved this merge request

    approved this merge request

  • merged

  • dakkar mentioned in commit 9de42228

    mentioned in commit 9de42228

  • Please register or sign in to reply
    Loading