Skip to content
Snippets Groups Projects

Fall back to port 3000 if none is specified

Merged 4censord requested to merge 4censord/Sharkey:minor-config-improvements into develop

What does this PR do?

Makes some minor QOL improvements to config file handeling and defautls. Speciffically:

  • Log if zero config files are loaded
  • Fall back on port 3000 if none is specified, instead of listening on NaN

By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request
Edited by 4censord

Merge request reports

Merge request pipeline #938 failed

Merge request pipeline failed for e1b0faa1

Merged by dakkardakkar 4 months ago (Aug 6, 2024 9:23am UTC)

Loading

Pipeline #951 canceled

Pipeline canceled for 76a96604 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • dakkar
  • 4censord added 2 commits

    added 2 commits

    • 207736d9 - Complain if no config-files are loaded
    • a9a1f9dd - Fall back to port 3000 if none is specified

    Compare with previous version

  • 4censord resolved all threads

    resolved all threads

  • dakkar resolved all threads

    resolved all threads

  • dakkar approved this merge request

    approved this merge request

    • Author Contributor
      Resolved by dakkar

      Another thing i noticed because of this: it loads the config file different 4 times during startup. (because the no file loaded apears different 4 times in the log)

  • 4censord added 2 commits

    added 2 commits

    • f1b01b2c - Complain if no config-files are loaded
    • 0d16e4f0 - Fall back to port 3000 if none is specified

    Compare with previous version

  • 4censord reset approvals from @dakkar by pushing to the branch

    reset approvals from @dakkar by pushing to the branch

  • 4censord added 2 commits

    added 2 commits

    • 12aeaa5f - Complain if no config-files are loaded
    • e1b0faa1 - Fall back to port 3000 if none is specified

    Compare with previous version

  • dakkar resolved all threads

    resolved all threads

  • this should work fine, yes; I guess you have tested this latest version, too.

  • dakkar approved this merge request

    approved this merge request

  • 4censord changed the description

    changed the description

  • 4censord mentioned in merge request !588 (merged)

    mentioned in merge request !588 (merged)

  • Hazelnoot
  • Hazelnoot approved this merge request

    approved this merge request

  • dakkar resolved all threads

    resolved all threads

  • dakkar mentioned in commit 76a96604

    mentioned in commit 76a96604

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading