Add icon for moving files/folders - for !583
What does this PR do? (Please give us a brief description of what this PR does.)
This is for !583 (merged) since Phosphor Icons did not have a move icon for folders/files I quickly threw together one from the arrow icon and folder icon of Phosphor to try and make it look like Tabler's this essentially can be used as a proper drop-in replacement.
Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines
-
I agree to follow this project's Contribution Guidelines -
I have made sure to test this pull request
Merge request reports
Activity
ooh, I hadn't noticed we had a custom icon font! thank you!
where is the source for it? the AGPL requires including the "complete corresponding source code", so not just the "preferred form for modifications" (if you wrote the SVG directly, that's it), but also the build tooling (so, at the very least, a document explaining how to generate the various formats; a script or makefile or whatever you used to do it would also help)
- Resolved by dakkar
For the SVG itself I simply just downloaded it straight from Phosphor's website by clicking on an icon and then downloading the raw SVG and editing it in inkscape.
It was still broken then cause icon fonts don't like it if it isn't just a path so I also had to use https://docs.oslllo.com/svg-fixer/master/#/ to fix it and then removed the fill line that it added for some reason which caused the icon to be red.
As for the Font side I used https://fontastic.me/ so I can't really say much on how to actually create a Icon Font myself.
added enhancement label
added from-upstream label
removed from-upstream label
reset approvals from @fEmber by pushing to the branch
- Resolved by Marie
- Resolved by dakkar
last bit: we'll need something like https://activitypub.software/TransFem-org/Sharkey/-/blob/develop/scripts/build-assets.mjs?ref_type=heads#L39-50 to tweak the
style.css
so that it appends?version=...
to the font url, otherwise new versions of the font won't be picked up by browsers/cachesI'm not sure what's the best way to do that?
added 1 commit
- 10334363 - chore: add note about updating css and font files