Skip to content
Snippets Groups Projects

Remove infinite caches to prevent memory leak

Merged Hazelnoot requested to merge fEmber/Sharkey:hazelnoot/600-remove-infinite-caches into develop
All threads resolved!

What does this PR do? (Please give us a brief description of what this PR does.)

This PR resolves #600 (closed) and #601 (closed) by replacing all "infinite" cache lifetimes and cleaning up MemoryKVCache<T>. Expiration lifetimes of all memory / redis caches have been reset to a reasonable number and normalized between similar caches. Redis caches have a synchronization fix, and an optimization is applied to MemoryKVCache.gc().

This is a smaller, more narrow-focused PR that replaces !580 (closed). A similar PR is open for Misskey: https://github.com/misskey-dev/misskey/pull/14363

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request
Edited by Hazelnoot

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hazelnoot changed the description

    changed the description

  • dakkar approved this merge request

    approved this merge request

  • added bugbackend label

  • Hazelnoot added bugfrontend label and removed bugbackend label

    added bugfrontend label and removed bugbackend label

  • removed enhancement label

  • Hazelnoot added 1 commit

    added 1 commit

    Compare with previous version

  • Hazelnoot reset approvals from @dakkar by pushing to the branch

    reset approvals from @dakkar by pushing to the branch

  • Ghost User approved this merge request

    approved this merge request

  • Marie approved this merge request

    approved this merge request

  • dakkar
  • dakkar resolved all threads

    resolved all threads

  • Hazelnoot resolved all threads

    resolved all threads

  • merged

  • dakkar mentioned in commit 4e7df7a5

    mentioned in commit 4e7df7a5

  • Hazelnoot added bug::backend label and removed bug::frontend label

    added bug::backend label and removed bug::frontend label

  • Please register or sign in to reply
    Loading