fix `offsetMode` in `MkPagination` - fixes #622
What does this PR do?
3f73251d reworked the way offsetMode
is handled, to allow reactive ComputedRef<boolean>
in addition to a
simple boolean
, so that custom emoji search could easily switch
between the faster sinceId
/untilId
pagination and the slower
offset
as needed.
Or it would have, if I had written the correct expression! I wrote
props.offsetMode
instead of props.pagination.offsetMode
, so it was
always false
I have no idea how I didn't notice, I swear I tested it
Anyway, factoring out the nested ternaries makes the whole thing clearer and less prone to mistakes. And I have tested it, this time.
@kio could you cherry-pick this commit into your fork and test it?
Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines
-
I agree to follow this project's Contribution Guidelines -
I have made sure to test this pull request
Merge request reports
Activity
changed title from fix
off{-e-}stMode
inMkPagination
- fixes #622 (closed) to fixoffs{+e+}tMode
inMkPagination
- fixes #622 (closed)- Resolved by dakkar
Yes! This commit works. Please disregard my previous comment.
mentioned in commit d03c9f4b