Skip to content
Snippets Groups Projects

fix: prevent error spam from ServerStatsService when running on Windows

Merged Hazelnoot requested to merge fEmber/Sharkey:hazelnoot/fix-stats-errors into develop

What does this PR do? (Please give us a brief description of what this PR does.)

This PR fixes a bug that results in an error spammed to the server console when running on windows. The root cause is incorrect typings for the systeminformation package, which specify a non-null response while the library is perfectly capable of returning null on unsupported platforms. I fixed this by simply extending the current "ignore errors" logic to account for a null response.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading