Skip to content
Snippets Groups Projects

maybe fix #510 - try to not edit visibility

Merged maybe fix #510 - try to not edit visibility
All threads resolved!
Merged dakkar requested to merge feature/510-fix-visibility-in-edit into develop
All threads resolved!

What does this PR do?

The frontend part is pretty straghtforward: disable the visibility-related buttons if we're editing.

The backend part is… ugly.

As #510 (closed) says, changing the visibility of a note doesn't really work with federation. But, if you edit a note adding sensitive words, or if your user has been marked as "can't post publicly", or similar, then we want to change the visibility of the note.

This change should fix the obvious surface problem (ignoring any visibility or localOnly value coming from the frontend or another instance), without making things worse.

But please check my reasoning!!

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading