Skip to content
Snippets Groups Projects

Only accept HTML `<link rel="alternate">` on successful HTTP statuses

Merged Julia requested to merge feature/only-accept-html-alternate-on-success into develop
All threads resolved!

What does this PR do? This PR makes it such that ApRequestService no longer attempts to parse HTML responses to extract a <link rel="alternate" type="application/activity+json"> tag from the response unless the HTTP status is successful (200-299). This avoids incurring a performance penalty when calling ApRequestService.signedGet with the url of a server that is currently down, for one reason or another.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Julia added 2 commits

    added 2 commits

    • b667a68b - Use `res.ok` instead of 200-299
    • 5b282924 - Add `DetachedWindowAPI.close` calls

    Compare with previous version

  • Julia resolved all threads

    resolved all threads

  • dakkar
    • Resolved by Julia

      while you're here, also .close() the windows in MfmService: if these happy-dom structures are the cause of leak, MfmService creates many many more of them! (one for each activity we send!)

  • Julia added 1 commit

    added 1 commit

    • e4cbd588 - Remove superfluous `DetachedWindowAPI.close` call

    Compare with previous version

  • Julia mentioned in merge request !634 (merged)

    mentioned in merge request !634 (merged)

  • Julia resolved all threads

    resolved all threads

  • dakkar approved this merge request

    approved this merge request

  • Tess K approved this merge request

    approved this merge request

  • Hazelnoot approved this merge request

    approved this merge request

  • Marie approved this merge request

    approved this merge request

  • Julia mentioned in commit c94f6994

    mentioned in commit c94f6994

  • merged

  • Please register or sign in to reply
    Loading