Skip to content
Snippets Groups Projects

make MkAbuseReport more friendly for smaller screen sizes

Merged blueb requested to merge blueb/Sharkey:nicer-reports-page into develop
All threads resolved!

What does this PR do? (Please give us a brief description of what this PR does.) Currently, Sharkey inherits the design of Misskey's report element. On smaller screen sizes, it doesn't look great. This improves the current look by making the side section of the user being reported go on the top of the report and adds spacing between the resolve button and forward switch.

New:

image image Previous:

image image

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request
Edited by blueb

Merge request reports

Merge request pipeline #1304 failed

Merge request pipeline failed for 04c729e5

Merged by dakkardakkar 6 months ago (Oct 3, 2024 3:57pm UTC)

Loading

Pipeline #1307 passed

Pipeline passed for bc8c6592 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by dakkar

      thank you! I like your design!

      given that this component is pretty small, and you've essentially rewritten half of it, I feel it would be more future-friendly if instead we had our own SkAbuseReport.vue with your code in it… opinions?

  • blueb added 1 commit

    added 1 commit

    • 5ef58c90 - replace brs with margin in MkAbuseReport

    Compare with previous version

  • Nice work with this!

  • dakkar resolved all threads

    resolved all threads

  • dakkar approved this merge request

    approved this merge request

  • Marie approved this merge request

    approved this merge request

  • Hazelnoot approved this merge request

    approved this merge request

    • Resolved by Hazelnoot

      There's a lint error:

      /builds/blueb/Sharkey/packages/frontend/src/components/MkAbuseReport.vue
        37:26  error  Attribute "v-if" should go before "class"  vue/attributes-order
      ✖ 1 problem (1 error, 0 warnings)
        1 error and 0 warnings potentially fixable with the `--fix` option.
  • blueb added 1 commit

    added 1 commit

    • 04c729e5 - fix: lint error in MkAbuseReport

    Compare with previous version

  • blueb reset approvals from @Marie, @dakkar, and @fEmber by pushing to the branch

    reset approvals from @Marie, @dakkar, and @fEmber by pushing to the branch

  • dakkar approved this merge request

    approved this merge request

  • Hazelnoot approved this merge request

    approved this merge request

  • Hazelnoot resolved all threads

    resolved all threads

  • merged

  • dakkar mentioned in commit bc8c6592

    mentioned in commit bc8c6592

  • (Bit off-topic) MkAbuseReport and related backend things are currently being enhanced upstream. See https://github.com/misskey-dev/misskey/pull/14704

  • Please register or sign in to reply
    Loading