Skip to content

Check if time-based achievements are unlocked before initializing them in main-boot

Evangelos Paterakis requested to merge GeopJr/Sharkey:feat/avoid-initializing-time-based-achievement-checking-if-unlocked into develop

What does this PR do? (Please give us a brief description of what this PR does.)

This MR only initializes claimAchievement checking processes that depend on setInterval and setTimeout in main-boot, only if they haven't been claimed already.

My main issue is actually justPlainLucky, which runs every 10 seconds, regardless if the user has the achievement already or not. The setTimeout ones are not that big of an issue and wouldn't mind reverting the changes for them if needed.

Alternatively, on my instance, I have replaced justPlainLucky with a 0.05% chance that runs once when main-boot is loaded instead of every x seconds. Let me know if I should MR that instead! (GeopJr/Sharkey@88007501)

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports