Skip to content
Snippets Groups Projects

Prevent deletion or suspension of system accounts (resolves #625)

Merged Hazelnoot requested to merge fEmber/Sharkey:hazelnoot/625-protect-system-accounts into develop
All threads resolved!

What does this PR do?

This PR defines a new isSystemAccount function to consolidate common logic, then uses that function to reject any attempt to delete or suspend a system account (currently, instance.actor and relay.actor). Resolves #625 (closed).

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request
Edited by Hazelnoot

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hazelnoot added 1 commit

    added 1 commit

    Compare with previous version

  • dakkar
  • dakkar approved this merge request

    approved this merge request

    • Developer
      Resolved by Hazelnoot

      I think a check should also be placed into the login or change password section to prevent people from logging into the system users as was done before once.

  • Marie resolved all threads

    resolved all threads

  • Hazelnoot added 79 commits

    added 79 commits

    • 39214431...32a97a5a - 77 commits from branch TransFem-org:develop
    • 126a2fcf - Merge branch 'develop' into hazelnoot/625-protect-system-accounts
    • cd9bce30 - prevent login and password reset for system accounts

    Compare with previous version

  • Hazelnoot reset approvals from @dakkar by pushing to the branch

    reset approvals from @dakkar by pushing to the branch

  • Hazelnoot resolved all threads

    resolved all threads

  • dakkar approved this merge request

    approved this merge request

  • Marie enabled an automatic merge when all merge checks for cd9bce30 pass

    enabled an automatic merge when all merge checks for cd9bce30 pass

  • Marie approved this merge request

    approved this merge request

  • merged

  • Marie mentioned in commit ba5eec21

    mentioned in commit ba5eec21

  • Please register or sign in to reply
    Loading