Skip to content
Snippets Groups Projects

Allow logged in users to refresh polls

Merged Marie requested to merge feat/refreshpoll into develop
All threads resolved!

What does this PR do?

Allows users to refresh polls (this only works on remote polls for local polls clicking refresh does nothing)

Had to modify the ApQuestionService file a tiny bit so instead of doing a !== check it now does a !( > ) check

I only was able to test it with a few polls locally by pulling in the poll on the local instance and on my akkoma instance and then voting for a choice on both followed by waiting 3-4 minutes before clicking refresh due to caching.

Closes #743 (closed)

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Merge request pipeline #1531 passed

Merge request pipeline passed for 4128b387

Merged by MarieMarie 4 months ago (Oct 18, 2024 9:03pm UTC)

Merge details

Pipeline #1564 canceled

Pipeline canceled for 290bfd20 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hazelnoot
  • Hazelnoot
  • Marie added 1 commit

    added 1 commit

    • daf61b05 - upd: hide refresh if logged out and if local, change blocked error message

    Compare with previous version

  • Marie resolved all threads

    resolved all threads

  • Marie requested review from @fEmber

    requested review from @fEmber

  • Marie added 1 commit

    added 1 commit

    Compare with previous version

  • Marie resolved all threads

    resolved all threads

  • dakkar
  • Marie added 1 commit

    added 1 commit

    • 30836687 - chore: change permission kind

    Compare with previous version

  • Marie resolved all threads

    resolved all threads

  • Marie added 1 commit

    added 1 commit

    Compare with previous version

    • Resolved by Hazelnoot

      I've tried to test this locally but I can't get misskey to communicate with sharkey (for testing on a remote post, since you need a remote post to refresh) because of self-signed certificates and shit, so if someone else could review and approve this that would be great.

  • Hazelnoot added 40 commits

    added 40 commits

    • 72313777...68b90df0 - 34 commits from branch develop
    • dd58a4aa - upd: add ability to refresh poll
    • 00bb9588 - chore: change string to locale
    • 61cb46b1 - upd: hide refresh if logged out and if local, change blocked error message
    • 6b561639 - upd: change condition
    • dedb24fe - chore: change permission kind
    • 4128b387 - chore: update misskey-js

    Compare with previous version

  • Hazelnoot resolved all threads

    resolved all threads

  • Hazelnoot approved this merge request

    approved this merge request

  • Marie enabled an automatic merge when all merge checks for 4128b387 pass

    enabled an automatic merge when all merge checks for 4128b387 pass

  • dakkar approved this merge request

    approved this merge request

  • merged

  • Marie mentioned in commit 290bfd20

    mentioned in commit 290bfd20

  • added federation label

  • Please register or sign in to reply
    Loading