Allow logged in users to refresh polls
What does this PR do?
Allows users to refresh polls (this only works on remote polls for local polls clicking refresh does nothing)
Had to modify the ApQuestionService file a tiny bit so instead of doing a !==
check it now does a !( > )
check
I only was able to test it with a few polls locally by pulling in the poll on the local instance and on my akkoma instance and then voting for a choice on both followed by waiting 3-4 minutes before clicking refresh due to caching.
Closes #743 (closed)
Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines
-
I agree to follow this project's Contribution Guidelines -
I have made sure to test this pull request
Merge request reports
Activity
added enhancement label
- Resolved by Marie
- Resolved by Marie
- Resolved by Marie
added 1 commit
- daf61b05 - upd: hide refresh if logged out and if local, change blocked error message
requested review from @fEmber
- Resolved by Marie
- Resolved by Hazelnoot
I've tried to test this locally but I can't get misskey to communicate with sharkey (for testing on a remote post, since you need a remote post to refresh) because of self-signed certificates and shit, so if someone else could review and approve this that would be great.
added 40 commits
-
72313777...68b90df0 - 34 commits from branch
develop
- dd58a4aa - upd: add ability to refresh poll
- 00bb9588 - chore: change string to locale
- 61cb46b1 - upd: hide refresh if logged out and if local, change blocked error message
- 6b561639 - upd: change condition
- dedb24fe - chore: change permission kind
- 4128b387 - chore: update misskey-js
Toggle commit list-
72313777...68b90df0 - 34 commits from branch
enabled an automatic merge when all merge checks for 4128b387 pass
mentioned in commit 290bfd20
added federation label