Skip to content
Snippets Groups Projects

Feat: Flash playback using Ruffle

Merged Charlotte requested to merge CenTdemeern1/Sharkey:feat/ruffle into develop

What does this MR do?

Fixes #694 (closed).
This merge request introduces Shockwave Flash playback support using the Ruffle emulator.

Thanks to all the people who helped make this possible:

Debugging:

  • From the Ruffle team: kjarosh, Dinnerbone, nosamu
  • From the Sharkey team & contributors: Julia, hazelnoot, dakkar, piuvas
  • Others: Freeplay

JP translation/localization: Henma

Reviewing (so far): Julia, hazelnoot, dakkar

And of course, the Ruffle project and its contributors!

This MR is standing on the shoulders of giants

Contribution Guidelines

By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this merge request
Edited by Charlotte

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Julia
  • Julia
  • Julia
  • Julia requested changes

    requested changes

    • Resolved by Charlotte

      Oh, I missed it in my review, but- this component needs to be localized, there's several examples of how that can be done throughout the repo.

  • Author Developer

    Thanks for the review, just note that I might not get to everything immediately though because there were some other things I needed to do first (for example, I need to make sure to disable hotkeys when the flash player is in focus first)

  • Charlotte added 1 commit

    added 1 commit

    • 62b42812 - Add the ruffle-player to the hotkey ignorelist

    Compare with previous version

  • Charlotte added 1 commit

    added 1 commit

    • 45223aca - Always load Ruffle from CDN and add it as a dependency

    Compare with previous version

  • Charlotte added 2 commits

    added 2 commits

    • 020a6ba2 - Add Ruffle type definitions
    • fc51fcec - Dynamic loading, error handling, and types

    Compare with previous version

  • Charlotte added 1 commit

    added 1 commit

    • c65d9dda - Use esm.sh instead of unpkg as Ruffle CDN

    Compare with previous version

  • Charlotte added 1 commit

    added 1 commit

    • 079d646e - Use esm.sh instead of unpkg as Ruffle CDN

    Compare with previous version

  • Charlotte added 1 commit

    added 1 commit

    • 2a49e1f1 - Use esm.sh instead of unpkg as Ruffle CDN

    Compare with previous version

  • Charlotte added 2 commits

    added 2 commits

    • 25d421d9 - Change error handler for flash file load fail
    • 04268958 - Use esm.sh instead of unpkg as Ruffle CDN

    Compare with previous version

  • Author Developer

    I should mention that, right now, the code is nonfunctional; I've been forced to change the CDN from unpkg to esm.sh which is not actually compatible with Ruffle since it tries to convert stuff to ESM which Ruffle does not support (for example, when loading a JS file it needs the contents of, esm.sh instead serves the equivalent of an ESM redirect instead of the actual content which is not what Ruffle needs and then it breaks)

    I might drop that commit later, or I might change it to raw.esm.sh, but both options require a CSP change which is less than preferable

    Edited by Charlotte
  • Charlotte added 1 commit

    added 1 commit

    Compare with previous version

  • Author Developer

    Should clicking hyperlinks inside of flash media maybe be disabled?

  • Charlotte added 1 commit

    added 1 commit

    Compare with previous version

  • Author Developer

    This commit has been sitting on my local branch for a day now so I'll just push it. I tested it on dev and prod and it works fine, at least for me (I probably don't have the reverse proxy and CSP stuff set up right, but at this point I'm just going to push it so someone else can test it)

    Edited by Charlotte
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading