Feat: Flash playback using Ruffle
What does this MR do?
Fixes #694 (closed).
This merge request introduces Shockwave Flash playback support using the Ruffle emulator.
Thanks to all the people who helped make this possible:
Debugging:
- From the Ruffle team: kjarosh, Dinnerbone, nosamu
- From the Sharkey team & contributors: Julia, hazelnoot, dakkar, piuvas
- Others: Freeplay
JP translation/localization: Henma
Reviewing (so far): Julia, hazelnoot, dakkar
And of course, the Ruffle project and its contributors!
This MR is standing on the shoulders of giants
Contribution Guidelines
By submitting this merge request, you agree to follow our Contribution Guidelines
-
I agree to follow this project's Contribution Guidelines -
I have made sure to test this merge request
Merge request reports
Activity
added enhancement label
- Resolved by Charlotte
- Resolved by Charlotte
- Resolved by Charlotte
- Resolved by Charlotte
- Resolved by Charlotte
Oh, I missed it in my review, but- this component needs to be localized, there's several examples of how that can be done throughout the repo.
added 1 commit
- 62b42812 - Add the ruffle-player to the hotkey ignorelist
added 1 commit
- 45223aca - Always load Ruffle from CDN and add it as a dependency
added 2 commits
I should mention that, right now, the code is nonfunctional; I've been forced to change the CDN from unpkg to esm.sh which is not actually compatible with Ruffle since it tries to convert stuff to ESM which Ruffle does not support (for example, when loading a JS file it needs the contents of, esm.sh instead serves the equivalent of an ESM redirect instead of the actual content which is not what Ruffle needs and then it breaks)
I might drop that commit later, or I might change it to raw.esm.sh, but both options require a CSP change which is less than preferable
Edited by CharlotteThis commit has been sitting on my local branch for a day now so I'll just push it. I tested it on dev and prod and it works fine, at least for me (I probably don't have the reverse proxy and CSP stuff set up right, but at this point I'm just going to push it so someone else can test it)
Edited by Charlotte