Fix activity verification after key rotation
All threads resolved!
All threads resolved!
What does this PR do?
Fixes two minor bugs in the key re-fetch logic:
- After a user's keys rotate, the very next activity will fail to validate. All further ones succeed.
- If a user's keys are deleted for some reason, they will stick around in the cache for up to 12 hours.
Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines
-
I agree to follow this project's Contribution Guidelines -
I have made sure to test this pull request
Edited by Hazelnoot
Merge request reports
Activity
Filter activity
- Resolved by dakkar
- Resolved by Hazelnoot
added 1 commit
- 7b536e7b - normalize re-fetch logic between InboxProcessorService and ActivityPubServerService
added 11 commits
-
7b536e7b...b15f2575 - 7 commits from branch
TransFem-org:develop
- 42dcff3a - remove cached public keys after deletion
- 9fada7b2 - fix public key re-fetch logic
- 2544e71d - log key rotation
- 6d5b4464 - normalize re-fetch logic between InboxProcessorService and ActivityPubServerService
Toggle commit list-
7b536e7b...b15f2575 - 7 commits from branch
added bugbackend label
added 31 commits
-
6d5b4464...68b90df0 - 27 commits from branch
TransFem-org:develop
- 7c04c7a5 - remove cached public keys after deletion
- 8acb5502 - fix public key re-fetch logic
- 7d99797c - log key rotation
- 98996d03 - normalize re-fetch logic between InboxProcessorService and ActivityPubServerService
Toggle commit list-
6d5b4464...68b90df0 - 27 commits from branch
added 273 commits
-
98996d03...ba17776b - 269 commits from branch
TransFem-org:develop
- 94382777 - remove cached public keys after deletion
- 42cd070c - fix public key re-fetch logic
- 144178ec - log key rotation
- 05bfab22 - normalize re-fetch logic between InboxProcessorService and ActivityPubServerService
Toggle commit list-
98996d03...ba17776b - 269 commits from branch
reset approvals from @dakkar by pushing to the branch
added 61 commits
-
05bfab22...55df1ad1 - 57 commits from branch
TransFem-org:develop
- 78a75171 - remove cached public keys after deletion
- 5eb9a263 - fix public key re-fetch logic
- c0a5955e - log key rotation
- 27b502fa - normalize re-fetch logic between InboxProcessorService and ActivityPubServerService
Toggle commit list-
05bfab22...55df1ad1 - 57 commits from branch
enabled an automatic merge when all merge checks for 27b502fa pass
mentioned in commit 6e5cbedc
added federation label
Please register or sign in to reply