Skip to content
Snippets Groups Projects

Fix activity verification after key rotation

Merged Hazelnoot requested to merge fEmber/Sharkey:hazelnoot/fix-key-rotation into develop
All threads resolved!

What does this PR do?

Fixes two minor bugs in the key re-fetch logic:

  • After a user's keys rotate, the very next activity will fail to validate. All further ones succeed.
  • If a user's keys are deleted for some reason, they will stick around in the cache for up to 12 hours.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request
Edited by Hazelnoot

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • dakkar
  • Hazelnoot added 1 commit

    added 1 commit

    • 7b536e7b - normalize re-fetch logic between InboxProcessorService and ActivityPubServerService

    Compare with previous version

  • Hazelnoot added 11 commits

    added 11 commits

    • 7b536e7b...b15f2575 - 7 commits from branch TransFem-org:develop
    • 42dcff3a - remove cached public keys after deletion
    • 9fada7b2 - fix public key re-fetch logic
    • 2544e71d - log key rotation
    • 6d5b4464 - normalize re-fetch logic between InboxProcessorService and ActivityPubServerService

    Compare with previous version

  • added bugbackend label

  • dakkar resolved all threads

    resolved all threads

  • dakkar approved this merge request

    approved this merge request

  • Hazelnoot added 31 commits

    added 31 commits

    • 6d5b4464...68b90df0 - 27 commits from branch TransFem-org:develop
    • 7c04c7a5 - remove cached public keys after deletion
    • 8acb5502 - fix public key re-fetch logic
    • 7d99797c - log key rotation
    • 98996d03 - normalize re-fetch logic between InboxProcessorService and ActivityPubServerService

    Compare with previous version

  • Hazelnoot added 273 commits

    added 273 commits

    • 98996d03...ba17776b - 269 commits from branch TransFem-org:develop
    • 94382777 - remove cached public keys after deletion
    • 42cd070c - fix public key re-fetch logic
    • 144178ec - log key rotation
    • 05bfab22 - normalize re-fetch logic between InboxProcessorService and ActivityPubServerService

    Compare with previous version

  • Hazelnoot reset approvals from @dakkar by pushing to the branch

    reset approvals from @dakkar by pushing to the branch

  • dakkar approved this merge request

    approved this merge request

  • Hazelnoot added 61 commits

    added 61 commits

    • 05bfab22...55df1ad1 - 57 commits from branch TransFem-org:develop
    • 78a75171 - remove cached public keys after deletion
    • 5eb9a263 - fix public key re-fetch logic
    • c0a5955e - log key rotation
    • 27b502fa - normalize re-fetch logic between InboxProcessorService and ActivityPubServerService

    Compare with previous version

  • Hazelnoot marked this merge request as ready

    marked this merge request as ready

  • Hazelnoot marked the checklist item I have made sure to test this pull request as completed

    marked the checklist item I have made sure to test this pull request as completed

  • Hazelnoot enabled an automatic merge when all merge checks for 27b502fa pass

    enabled an automatic merge when all merge checks for 27b502fa pass

  • Marie approved this merge request

    approved this merge request

  • Hazelnoot mentioned in commit 6e5cbedc

    mentioned in commit 6e5cbedc

  • merged

  • added federation label

  • Please register or sign in to reply
    Loading