Skip to content
Snippets Groups Projects

Revert "Experimental: dont mark backfetched notes as silent"

Merged dakkar requested to merge feature/revert-mr-655 into develop

What does this PR do?

The intent of Dont mark backfetched notes as silent (!655 - merged) was to get notifications working in case a note was received via a relay before it gets received from the originating instance.

As a side-effect, all notes fetched get pushed to timelines (usually you only see them in the globla timeline). For example, let's say I fetch an old note because someone linked to it, or I want to quote it, or something. Now everybody on my instance sees that note as if it were new. This is going to confuse people.

Also, if I fetch a note, all its "upthread" is going to be fetched and show up in the timelines (not only the global one, but also people's home timelines if they follow the author of the newly-fetched old note).

Also every newly-fetched user's pinned notes, in a random order (yes, I just tested this).

I feel we need more smarts here (might need a middle ground between "silent" and "push everywhere as if it were new"), but I would prefer to not have this behaviour in 2024.9, and re-introduce it later once we make it smarter.

See also https://s.thenautilus.net/notes/9zmkqyms1w

(cc @Latte_macchiato)

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply