Skip to content
Snippets Groups Projects

Add followers tab to following feed + fix duplication (resolves #729)

Merged Hazelnoot requested to merge fEmber/Sharkey:hazelnoot/729-add-followers-tab into develop
All threads resolved!

What does this PR do?

This PR adds a new "Followers" tab to the following feed page. The followers tab contains, as you might expect, the most recent post by all people who follow the current user. Additionally, the PR adds missing error messages to the notes/following endpoint and fixes the main query to avoid duplicate entries for a single user.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Developer
      Resolved by Hazelnoot

      can we add a warning like we do for remote notes and remote profiles, "this view may be incomplete if nobody on this instance follows some of these people" or whatever?

  • Hazelnoot added 7 commits

    added 7 commits

    • 560df19f...24ecef80 - 3 commits from branch TransFem-org:develop
    • 6430a191 - fix duplicate users in the following feed
    • 053b47d7 - return error when calling following feed with both includeReplies and filesOnly
    • 04654b2f - add "followers" tab to following feed
    • bc45ff21 - add warning about incomplete remote data on following feed

    Compare with previous version

  • Hazelnoot resolved all threads

    resolved all threads

  • Hazelnoot enabled an automatic merge when all merge checks for bc45ff21 pass

    enabled an automatic merge when all merge checks for bc45ff21 pass

  • dakkar approved this merge request

    approved this merge request

  • Marie approved this merge request

    approved this merge request

  • merged

  • Hazelnoot mentioned in commit 42e2a586

    mentioned in commit 42e2a586

  • Please register or sign in to reply
    Loading