Skip to content
Snippets Groups Projects

Dockerfile mkdir files

Merged Rachel Y requested to merge transitory/Sharkey:dockerfile-mkdir-files into develop

What does this PR do? (Please give us a brief description of what this PR does.)

This is a bit of an an edge case I'll admit

The issue:

When:

  • Running as read-only root filesystem
  • Config is mounted in as a configmap
  • /tmp is mounted as a volume
  • s3 storage is configured
  • internal drive storage is not used

In this situation when InternalStorageService is instantiated here sharkey crashes because it can't mkdir the /sharkey/files directory. If s3 is enabled this directory isn't even used as far as I know.

An alternative would be to not initialize the internalstorageservice at all if s3 is enabled but I don't know if that would cause other side effects.

As a workaround I just had a tmp directory get mounted to /sharkey/files but that feels mildly hacky

Also running readonlyrootfs is rare as is and anyone who runs enough services like this will figure out the workaround so do with this what you will :)

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply