Skip to content
Snippets Groups Projects

Prevent "mark instance as NSFW" from producing hellspawns

Merged Hazelnoot requested to merge fEmber/Sharkey:hazelnoot/fix-mark-as-nsfw-hellspawn into develop
All threads resolved!

What does this PR do?

Prevent "mark instance as NSFW" from applying to boosts. This fixes a bug where boosts by a user from a NSFW instance are incorrectly converted into quotes despite existing as boosts on all remote instances (AKA hellspawns). Local users are able to react or reply to the fake "quote", but those activities are rejected by all remote instances. It's effectively a federation-killer.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • dakkar
  • Hazelnoot added 2 commits

    added 2 commits

    • 213a634f - remove duplicate `isPureRenote` method
    • ac1e94ca - quote all symbols in hellspawn upgrade script

    Compare with previous version

  • Hazelnoot resolved all threads

    resolved all threads

  • dakkar approved this merge request

    approved this merge request

  • Tess K approved this merge request

    approved this merge request

  • Hazelnoot added 62 commits

    added 62 commits

    • ac1e94ca...41536480 - 58 commits from branch TransFem-org:develop
    • a62e4f1c - ignore `isNSFW` for pure renotes
    • eb1e3268 - add script to fix hellspawns
    • c9934c37 - remove duplicate `isPureRenote` method
    • cc394d9a - quote all symbols in hellspawn upgrade script

    Compare with previous version

  • Hazelnoot mentioned in commit 241b186a

    mentioned in commit 241b186a

  • merged

  • added federation label

  • Please register or sign in to reply
    Loading