Skip to content
Snippets Groups Projects

Don't preview URLs to blocked hosts

Merged Hazelnoot requested to merge fEmber/Sharkey:hazelnoot/filter-url-preview-service into develop
All threads resolved!

What does this PR do?

Reject calls to /url (the URL preview endpoint) if the requested URL points to a blocked host.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Hazelnoot

      this will work nicely with my idea of getting the frontend to show links-to-AP-notes as quotes! (essentially: if the url preview says "activitypub", call ap/show and then patch the quote value in the note object in the frontend)

  • dakkar approved this merge request

    approved this merge request

  • Hazelnoot resolved all threads

    resolved all threads

  • Hazelnoot resolved all threads

    resolved all threads

  • Tess K approved this merge request

    approved this merge request

  • Hazelnoot added 59 commits

    added 59 commits

    Compare with previous version

  • Hazelnoot reset approvals from @dakkar and @tess by pushing to the branch

    reset approvals from @dakkar and @tess by pushing to the branch

  • Hazelnoot added 32 commits

    added 32 commits

    • b5c35ff6...41536480 - 29 commits from branch TransFem-org:develop
    • c48faca7 - fix lint errors in UrlPreviewService
    • 4c6cec55 - verify that preview URL is valid
    • 2a4c432f - don't generate URL previews for blocked domains

    Compare with previous version

  • Hazelnoot enabled an automatic merge when all merge checks for 2a4c432f pass

    enabled an automatic merge when all merge checks for 2a4c432f pass

  • Tess K approved this merge request

    approved this merge request

  • dakkar approved this merge request

    approved this merge request

  • Hazelnoot mentioned in commit fadcabea

    mentioned in commit fadcabea

  • merged

  • added federation label

  • Please register or sign in to reply
    Loading