Skip to content
Snippets Groups Projects

only "publish to followers" when things really change - fixes #733

Merged dakkar requested to merge feature/733-less-profile-federation into develop
All threads resolved!

What does this PR do?

This is not very pretty, but it seems to work correctly.

My initial idea was to render the user both before and after applying the changes, and compare the renderings, but that adds quite a few DB queries (renderPerson fetches images and emoji) and I felt the not-even-that-simpler code was not worth the added cost.

Better ideas welcome!

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hazelnoot resolved all threads

    resolved all threads

  • Hazelnoot approved this merge request

    approved this merge request

  • Marie approved this merge request

    approved this merge request

  • dakkar mentioned in commit 3164e7b4

    mentioned in commit 3164e7b4

  • merged

  • Please register or sign in to reply
    Loading