Skip to content
Snippets Groups Projects

Make collapsed notes subscribe to stream

What does this MR do?

Previously, when the note was collapsed, it didn't get updates such as reactions from streaming server. This was a problem, as any change made to the post before it got uncollapsed would end up being ignored (as the post wasn't listening to them).

For example, consider a stream that looks like this.

o @someone: message A [a collapsed reply using "Collapse replies replied to" option]
|
/\ someone
\/ @someone
message B

-----

/\  someone
\/ @someone
message A

If message A at the bottom gets reacted to, and then a collapsed reply is viewed, it won't have a reaction.

This is fixed by using v-show rather than v-if to make sure the streaming server is notified early about post being visible.

Contribution Guidelines

By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this merge request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading