Skip to content
Snippets Groups Projects

Fix rate limits under multi-node environments

Merged Hazelnoot requested to merge fEmber/Sharkey:hazelnoot/atomic-rate-limits into develop
All threads resolved!

What does this MR do?

Replace read-modify-write with atomic operations and optimistic locking to ensure that rate limits are correct when multiple threads / processes are in use. This changes the algorithm and performance characteristics, which are now documented in SkRateLimiterService.md.

Contribution Guidelines

By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this merge request
Edited by Hazelnoot

Merge request reports

Merge request pipeline #2085 passed

Merge request pipeline passed for 755ff878

Approval is optional

Merged by HazelnootHazelnoot 1 week ago (Dec 15, 2024 4:53pm UTC)

Merge details

  • Changes merged into with fd0ecb22.
  • Deleted the source branch.

Pipeline #2133 passed

Pipeline passed for fd0ecb22 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • dakkar
  • dakkar
  • Hazelnoot added 1 commit

    added 1 commit

    • 1377873b - fix typos and wording in SkRateLimiterService.md

    Compare with previous version

  • Hazelnoot added 2 commits

    added 2 commits

    • 72d18602 - fix SkRateLimiterService tests
    • 755ff878 - clarify naming of legacy rate limit methods

    Compare with previous version

  • dakkar resolved all threads

    resolved all threads

  • dakkar approved this merge request

    approved this merge request

  • Hazelnoot mentioned in issue #842

    mentioned in issue #842

  • Hazelnoot enabled an automatic merge when all merge checks for 755ff878 pass

    enabled an automatic merge when all merge checks for 755ff878 pass

  • Marie approved this merge request

    approved this merge request

  • Hazelnoot mentioned in commit fd0ecb22

    mentioned in commit fd0ecb22

  • merged

  • Please register or sign in to reply
    Loading