Skip to content
Snippets Groups Projects

preview AP objects as quotes - fix #595

Merged dakkar requested to merge feature/595-preview-notes-as-quotes into develop
All threads resolved!

What does this MR do?

This teaches MkUrlPreview to use the activityPub element returned by Summaly. If it's present, we fetch whatever it points to, and if it's a note, we show it as if it were a normal quoted note.

A note containing such a URL ends up looking like this:

image

A note containing the same URL, but also actually quoting the note, only shows the real quote, not the preview-quote, because we're already filtering such duplicate URLs.

Of course if a note is a quote-renote and contains a URL to another note, we'll show both:

image

If we decide this is a bad idea, we could do <MkUrlPreview … :showAsQuote="!appearNote.renote"

A note containing a link to an AP object that's not a note looks normal:

image

Contribution Guidelines

By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this merge request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I propose that we use the variable "divider" for the style here, as that's what is used within the MkUrlPreview class. var(--divider); (although this is not what i got from vue rather just viewing transfem.social live so i am not sure what the vue variable is).

  • Author Developer

    since @puppygirlhornypost asked, I've changed the style:

    image

    first is a MkUrlPreview (styled like other URL previews), second is a real quote

    regular preview:

    image

    embedded note preview:

    image

  • dakkar added 1 commit

    added 1 commit

    • 2dfadc08 - style embedded note previews like normal previews

    Compare with previous version

  • dakkar added 1 commit

    added 1 commit

    • c52badee - only log preview error in dev mode

    Compare with previous version

  • Amber Null approved this merge request

    approved this merge request

  • dakkar added 1 commit

    added 1 commit

    • 5fd3e271 - only log preview error in dev mode

    Compare with previous version

  • Hazelnoot resolved all threads

    resolved all threads

  • Hazelnoot approved this merge request

    approved this merge request

  • dakkar mentioned in commit fcbf072e

    mentioned in commit fcbf072e

  • merged

  • Please register or sign in to reply
    Loading